New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow retrieving page attributes from other sites #6674
base: develop
Are you sure you want to change the base?
feat: allow retrieving page attributes from other sites #6674
Conversation
f0d0056
to
af36940
Compare
I think it can be useful, but probably we would need a test for it. I also see test failures, IDK if by changes this PR or pre-existing (and now fixed) |
Agree with @yakky, would need a test for this. |
Thanks for the quick feedback. @ianare thank you for the contribution. Would you be able to provide tests for it as mentioned above? It would also be great to get a changelog entry 👍 |
Nice! I had looked into tests initially but could not find anything testing these functions. Maybe I missed them, if so where should I look? Otherwise where should the tests live? Thanks |
@ianare the tests can be found in cms/tests, see also: and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a nice addition and implementation looks good
We definitely need a test for this and a changelog entry
@ianare please let me know if you need any support to handle the requested changes |
@@ -395,13 +396,13 @@ | |||
"changed_by", | |||
] | |||
|
|||
def get_value(self, context, name, page_lookup): | |||
def get_value(self, context, name, page_lookup, site): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
Summary
Allow the retrieval of page attributes from other sites.
Proposed changes in this pull request
When running a multi sub-domain site, it's often useful to get the page_attributes from other sites, for example in the footer or header.
Documentation checklist