Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sideframe history nav button wrapping #7655

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: sideframe history nav button wrapping #7655

wants to merge 3 commits into from

Conversation

wesleyboar
Copy link

@wesleyboar wesleyboar commented Sep 22, 2023 •
edited

Description

The "CMS Sideframe History" navigation's triangles should not wrap.

Related resources

Checklist

  • I have opened this pull request against develop
  • (N/A) I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

Testing

Screenshots from manual in situ testing.

Browser Problem Fix (1 pixel)
Brave1 brave - sidebar history nav buttons wrap - 65px brave - sidebar history nav buttons fit - 66px
Firefox firefox - sidebar history nav buttons wrap - 65px firefox - sidebar history nav buttons fit - 66px
Safari safari - sidebar history nav buttons wrap - 65px safari - sidebar history nav buttons fit - 66px

Footnotes

  1. Chromium-based. ↩

@wesleyboar
Copy link
Author

wesleyboar commented Sep 22, 2023 •
edited

Mention @NicolaiRidani in the PR so that a respective label can be applied — django bounty

Status
Paused until I confirm bug with basic Django CMS, not my own. See #7654 (comment).

@wesleyboar wesleyboar marked this pull request as draft September 23, 2023 20:34
@fsbraun fsbraun added the needs reproduction This issue might have been fixed during the last years label Nov 29, 2023
@wesleyboar wesleyboar mentioned this pull request Dec 7, 2023
Open
1 task
@wesleyboar wesleyboar marked this pull request as ready for review February 9, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs reproduction This issue might have been fixed during the last years
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sideframe History Nav Buttons Wrap
2 participants
@wesleyboar @fsbraun