New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Re-introduce page-level publish permission just as in v4.0 #7837
base: develop-4
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsbraun I was wondering if it's possible to have test covering this change, just so that if there are regressions in this part of code, we can catch it.
@vinitkumar The publish permissions are tested. When they were removed, they were removed with their tests... Now, this PR brings both permissions and tests back. |
Description
In django CMS version 4.1 the
can_publish
permission was removed. With the next release of djangocms-versioning it will support low-level publication permissions if the versioned content model supports it.This PR restores the
can_publish
permissions and its test as it was available in django CMS 4.0.Tests have been restored, too.
A (no-op) squashed migration was added to ensure that publish permissions are not lost during migration processes:
0035
removes page publish permissions (released in 4.1.0)0036
adds the page publish permissions back0035
replaces0035
and0036
with a no-opRelated resources
can_publish
permission from django CMS 4 core #7635Checklist
develop-4