New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #7859: allow special characters in page title #7868
Merged
fsbraun
merged 7 commits into
django-cms:develop-4
from
jrief:fix/gh-7859-special-chars-in-page-title
May 22, 2024
Merged
fix: #7859: allow special characters in page title #7868
fsbraun
merged 7 commits into
django-cms:develop-4
from
jrief:fix/gh-7859-special-chars-in-page-title
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrief
changed the title
fix #7859: allow special characters in page title
fix: #7859: allow special characters in page title
Apr 9, 2024
jrief
force-pushed
the
fix/gh-7859-special-chars-in-page-title
branch
from
April 9, 2024 09:13
2d8ed15
to
a17fe19
Compare
marksweb
reviewed
Apr 9, 2024
fsbraun
approved these changes
May 16, 2024
fsbraun
added a commit
that referenced
this pull request
May 22, 2024
* fix #7859: allow special characters in page title * Update test_templatetags.py * Fix ruff issues in test_templatetags.py * One more time: fix ruff issues in test_templatetags.py --------- Co-authored-by: Fabian Braun <fsbraun@gmx.de>
4 tasks
fsbraun
added a commit
that referenced
this pull request
May 24, 2024
* fix: Only switch to structure endpoint on viewport breakpoint if in edit mode (#7920) * fix: #7859: allow special characters in page title (#7868) * fix #7859: allow special characters in page title * Update test_templatetags.py * Fix ruff issues in test_templatetags.py * One more time: fix ruff issues in test_templatetags.py --------- Co-authored-by: Fabian Braun <fsbraun@gmx.de> * Add fix of #7928 * Update cms.structureboard.js --------- Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of escaping the page title, this PR just strips its HTML tags. This prevents XSS-attacks as well but keeps HTML entities. Otherwise a page title containing an
&
will be escaped to&
which looks ugly in the browser's tabs.Related resources
Checklist
develop-4