fix: Set toolbar direction based on toolbar language #7902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsbraun
changed the title
sakhawy
requested changes
May 2, 2024
…cms into fix/toolbar-language-rtl
|
The patch is minimal, though. We might find places with weird layout. I'll try to add a few more lines later. |
fsbraun
requested review from
sakhawy and
marksweb
and removed request for
sakhawy
|
Alright, I'll do some manual tests later! |
|
@sakhawy So, the polyfill should be complete ;-) |
|
Once, we have this merged, I'll chery-pick it into #7901 |
…cms into fix/toolbar-language-rtl
|
@sakhawy Can you give this a final check, so we can merge it. I would love to backport it to 3.11 and include it in 3.11.6 which I am about to release... |
sakhawy
requested changes
May 11, 2024
|
Well spotted, thank you! |
|
@sakhawy Fixed both resize cursor and missing polyfill patch. If you're good to go, let me know by approving the PR :-) |
marksweb
approved these changes
May 12, 2024
fsbraun
added a commit
to fsbraun/django-cms
that referenced
this pull request
May 12, 2024
4 tasks
fsbraun
added a commit
that referenced
this pull request
May 12, 2024
…7902) (#7914) * feat: Add RTL support to toolbar (#7871) * feat: Add RTL support to toolbar * fix: Add logical text-align value for toolbar dropdown * fix: Correctly calculate available width of toolbar * fix: Fix weird floating bug with toolbar more buttons * feat: Add RTL support to modal header and related components (#7863) * fix: structure board on the right for ltr * Fix: also use key-length of 200 for the actual cache-key of placeholders - missing "functionality" for changes of #7595 and #7657 * fix: Set toolbar direction based on toolbar language (#7902) * Fix: Merge remnant * Update make-release script --------- Co-authored-by: Moe <mohammadalsakhawy@gmail.com> Co-authored-by: Wolfgang Fehr <24782511+wfehr@users.noreply.github.com>
fsbraun
added a commit
to fsbraun/django-cms
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@sakhawy
This PR sets the toolbar text direction based on the toolbar language and not based on the document language.
This needs a "polyfill" to work with Chrome before 120 which is added at least in a basic version.
Related resources
Checklist
develop-4