Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for 'Missing form style' #111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michael-yin
Copy link

This PR is to help people who got #103 and #110

@tok3rat0r
Copy link

tok3rat0r commented Aug 10, 2022

Tried this with my current deployment on Heroku, unfortunately I ran into the problem that I was generating the CSS (using npm run build) at the heroku-postbuild stage whereas Python packages (needed to resolve pySitePackages) are installed after that point. I'm not sure how to run the script late enough to resolve pySitePackages correctly when deploying on Heroku.

@michael-yin
Copy link
Author

@tok3rat0r

It is better to use Docker to deploy on Heroku.

You can check https://github.com/AccordBox/django-tailwind-alpine-htmx to see how I deploy it on Heroku (which also use this project)

Thx.

@GitRon
Copy link
Contributor

GitRon commented Jan 11, 2024

Hi @michael-yin!

Is this MR still up-to-date?

Best
Ronny

@michael-yin
Copy link
Author

Hi, @GitRon

This method is still working and I am using it in my projects.

You can merge the PR if you want to.

Thx.

@GitRon
Copy link
Contributor

GitRon commented Jan 12, 2024

Hi @michael-yin

thanks for your answer! We've already addressed the issue with adding a link to Carltons blog to our docs. Here's the commit: 4422619

I know his solution works. Do you think that'll work for you?

Best
Ronny

Supplemental: I still think about adding Carltons solution to this package so people don't have to fiddle around with the configuration.

@michael-yin
Copy link
Author

@GitRon

It seems the solution focus on Django templates.

What if css class are written in Python code? https://github.com/django-crispy-forms/crispy-tailwind/blob/main/crispy_tailwind/layout.py

Would it work?

Thx.

@GitRon
Copy link
Contributor

GitRon commented Jan 19, 2024

Hi @michael-yin !

As far as I understand Carltons script, all Django apps (also the ones from third-party) will be added for the Tailwind CLI.
Please have a look at this management command, and check for yourself.

If you don't agree, I'd be happy to update the docs accordingly.

Best
Ronny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants