Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed update_attributes() to use same HTML5 attributes behavior for "_" and "-" #1149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed update_attributes() to use same HTML5 attributes behavior for "_" and "-" #1149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion crispy_forms/layout_slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from crispy_forms.bootstrap import Container
from crispy_forms.exceptions import DynamicError
from crispy_forms.layout import Fieldset, MultiField
from django.utils.html import conditional_escape


class LayoutSlice:
Expand Down Expand Up @@ -151,6 +152,7 @@ def update_attrs(layout_object):
layout_object.attrs["class"] += " %s" % kwargs.pop("css_class")
else:
layout_object.attrs["class"] = kwargs.pop("css_class")
layout_object.attrs.update(kwargs)
# We use kwargs as HTML attributes, turning data_id='test' into data-id='test'
layout_object.attrs.update({k.replace("_", "-"): conditional_escape(v) for k, v in kwargs.items()})

self.map(update_attrs)