Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Type Hints #1282

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Added Type Hints #1282

wants to merge 23 commits into from

Commits on Dec 30, 2022

  1. Added type hints. 

    Protocal only available in Py3.8+

Added ref to `render_context` fix to django-stubs.
    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    9009d1a View commit details
    Browse the repository at this point in the history

  2. Removed unused # type:ignore

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    2492511 View commit details
    Browse the repository at this point in the history

  3. Update as_crispy_form to avoid using Context

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    cd558a3 View commit details
    Browse the repository at this point in the history

  4. Updated _EngineTemplate to allow contex like objects

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    2c4b411 View commit details
    Browse the repository at this point in the history

  5. Type Tests pt1

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    262bbc7 View commit details
    Browse the repository at this point in the history

  6. Added more test return types

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    da0db1e View commit details
    Browse the repository at this point in the history

  7. Template, _EngineTemplate and Context Fixes 

    New types added in:
typeddjango/django-stubs@cb2f233

typeddjango/django-stubs@c3949b6
    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    f86ab0d View commit details
    Browse the repository at this point in the history

  8. Removed use of Dict, Union and Optional.

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    6380b8d View commit details
    Browse the repository at this point in the history

  9. Field.render() returns SafeString

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    17821ff View commit details
    Browse the repository at this point in the history

  10. List to list

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    c015bba View commit details
    Browse the repository at this point in the history

  11. Added flake8-type-checking linter 

    This ensures that imports are correctly guarded behind TYPE_CHECKING
    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    0e0bb69 View commit details
    Browse the repository at this point in the history

  12. Added ContextDict type alias

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    c83675d View commit details
    Browse the repository at this point in the history

  13. Add django-stubs myplugin

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    3de4622 View commit details
    Browse the repository at this point in the history

  14. Fixed context type for render_crispy_form

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    96a246f View commit details
    Browse the repository at this point in the history

  15. Added more types to test suite

    @smithdc1
    smithdc1 committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    c51d8da View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2022

  1. Added more test assertions

    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    7746c8d View commit details
    Browse the repository at this point in the history

  2. parse_form can also accept formsets.

    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    b4c76ae View commit details
    Browse the repository at this point in the history

  3. Added generic types to list_difference

    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    520a08a View commit details
    Browse the repository at this point in the history

  4. Legend and HTML can also accept translated strings.

    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    66dbbe3 View commit details
    Browse the repository at this point in the history

  5. Added LayoutObjectFields Type Alias

    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    7bafdb4 View commit details
    Browse the repository at this point in the history

  6. Drop html5 test 

    This functionality has been part of Django for some time.
    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    3653135 View commit details
    Browse the repository at this point in the history

  7. Pass Context not dict to CrispyFormNode.get_response_dict()

    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    b4c07d9 View commit details
    Browse the repository at this point in the history

  8. Add type to context dict.

    @smithdc1
    smithdc1 committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    3234967 View commit details
    Browse the repository at this point in the history