add css class to prepended/appended inline elements #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @masc-be -- thanks for the patch -- Would be good to see some examples of this. Currently I'm not sure the additional api is worth it. My gut reaction is to encourage folk to override the template and add additional styles in such a case. |
|
Hello,
sorry for the late reply. Was/am very stressed. Kids sick, Christmas, work [AHHHHH] ... So now to the topic of Bootstrap5 and crispy-forms. The input-group is perfect with its border to display related things. I know there is the label but that is not so well coherent from its position and from look and feel when it becomes more complex. I and also other designers have their problems with it. That's why the prepended or appended text is often misused. All we need is the ability to customize the content and classes. Here are a few simple examples: https://www.codeply.com/p/JChuEHBR8l
There is still a problem with my patch. Unfortunately, I only noticed it after the pull request. It was also not noticed during the test, as it does not restrict the functionality. The parameters "prepended_class" and "appended_class" are added to the "input" element with their content as an attribute. It does not interfere, as nobody evaluates such an attribute, but it absolutely has to be removed. I will check this immediately and make an update.
Thank you for your interest and have a Merry Christmas.
|
|
Now its looks fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I want to apply my own formatting to the "add-on" in the "input-group" element https://getbootstrap.com/docs/5.0/forms/input-group/, this is not possible due to the lack of parameterization. However, this would make sense if, for example, the background color or the size needs to be adjusted. In addition, css tricks could also be used to create nice effects. For this case I have created this patch in combination with the pull-request of crispy-bootstrap5.