New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemoryChannelLayer improvements, test fixes #1976

Open

devkral wants to merge 6 commits into django:main from devkral:fixes/inmemory

Contributor

devkral commented Feb 9, 2023

Improvements to InMemoryChannelLayer

honor expiry / don't block for eternity
honor per channel capacities
threadsafer cleaning design with atomic operations
parallel sending

Bugfixes tests

channel_layer is sometimes overwritten and the tests become bogus

devkral added 6 commits

February 9, 2023 11:21


          harden inmemory channel layer for threading, add missing expiry, fix …

88d3eed

…tests


          black formatting

c236b5a


          improve comments

eb25081


          black reformat

8b83b8f


          don't suppress other errors than ChannelFull

e3da586


          fix receive function

d93d1fa

Contributor Author

devkral commented Feb 16, 2023

Note: I made an mistake with:

honor expiry / don't block for eternity
This is the correct behavior for receive.
But maybe the receive method it should be put in a loop, in case the queue is expired
(see devkral/channels-multiprocessing for an example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment