New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure text message exists before handling on `WebsocketConsumer` #2097

Open

cacosandon wants to merge 1 commit into django:main from cacosandon:fix/hypercorn/websockets-message-handler

cacosandon commented May 2, 2024

When using uvicorn or daphne, only one of text or bytes is sent.

But on hypercorn, both of them are sent, but with None value:
https://github.com/pgjones/hypercorn/blob/31639ec2f4d03aa920b95c84686163901224c6cf/src/hypercorn/protocol/ws_stream.py#L159

So if you just send bytes, text will be None and you won't be able to handle the message.

I just add an extra check.


          fix(channels/generic): ensure text message exists before deciding to …

24d3a66

…handle

cacosandon mentioned this pull request

Django Channels Memory Leak on every message or connection #2094

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment