Localflavor Sri Lanka: Support for Sri Lanka added in django-localflavor #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudep
reviewed
Jul 28, 2023
docs/changelog.rst
Outdated
| @@ -27,6 +27,8 @@ Other changes: | |||
|
|
|||
| New flavors: | |||
|
|
|||
| - Sri Lanka LocalFlavor: Support for Sri Lanka added | |||
| (`gh-493 <https://github.com/django/django-localflavor/pull/493>`_). | |||
There was a problem hiding this comment.
You should not add any entry in notes of an already-released version. Please move that note above in the unreleased section.
For the rest, it looks rather good, and I hope @benkonrath will have the opportunity to make a detailed review during the next weeks. Thanks!
There was a problem hiding this comment.
Okay, I will make that change. I wasn't aware of it before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Support for Sri Lanka Added as requested by this issue #491 **
What Fields are added ?
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
New Fields Only
Prefix the country code to all fields.
Field names should be easily understood by developers from the target
localflavor country. This means that English translations are usually
not the best name unless it's for something standard like postal code,
tax / VAT ID etc.
Prefer 'PostalCodeField' for postal codes as it's
international English; ZipCode is a term specific to the United
States postal system.
Add meaningful tests. 100% test coverage is not required but all
validation edge cases should be covered.
Add
.. versionadded:: <next-version>comment markers to newlocalflavors.
Add documentation for all fields.