add tests for deriving filename as well

django · Apr 30, 2024 · bb1bfef · bb1bfef
1 parent 74937da
commit bb1bfef
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/tests/file_storage/test_generate_filename.py b/tests/file_storage/test_generate_filename.py
@@ -44,14 +44,19 @@ def test_storage_dangerous_paths(self):
             ("/tmp/.", "."),
             ("", ""),
         ]
-        s = FileSystemStorage()
+        storage = FileSystemStorage()
+        overwrite_storage = FileSystemStorage(allow_overwrite=True)
         msg = "Could not derive file name from '%s'"
         for file_name, base_name in candidates:
             with self.subTest(file_name=file_name):
                 with self.assertRaisesMessage(SuspiciousFileOperation, msg % base_name):
-                    s.get_available_name(file_name)
+                    storage.get_available_name(file_name)
+                with self.assertRaisesMessage(SuspiciousFileOperation, msg % base_name):
+                    storage.generate_filename(file_name)
+                with self.assertRaisesMessage(SuspiciousFileOperation, msg % base_name):
+                    overwrite_storage.get_available_name(file_name)
                 with self.assertRaisesMessage(SuspiciousFileOperation, msg % base_name):
-                    s.generate_filename(file_name)
+                    overwrite_storage.generate_filename(file_name)
 
     def test_storage_dangerous_paths_dir_name(self):
         candidates = [