New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #35303 -- Added async auth backends and associated functionality #18036
base: main
Are you sure you want to change the base?
Conversation
6ace5c4
to
2c59d74
Compare
Hi Jon! Thank you for your contribution. I see this is a draft PR, please remember that when this work is ready for review, you need to adjust the ticket flags in the Trac system so this PR gets added to the "branches needing review" section of the Django Developer Dahsboard. More information in these docs. |
734c921
to
b0dc084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bigfootjon — Thanks for this. It looks good.
I don't think there's anything we can do about it — certainly not to block this PR about it! – but, I still find the duplication over the function color a bit… erm… sad. 🙂 We've got ≈identical skeletons differing in ≈only whether the internal helper is awaited or not. It would be nice to reduce that where possible over time.
About half-way down, that caused me to start scanning a little, so I can't say I looked at every code path, but looks good at the high level. 👍
Hi @bigfootjon 👋 thank you for this PR |
Trac ticket number
ticket-35303
Branch description
This is the culmination of the project to asyncify the
contrib.auth
module. This PR contains 3 things:BaseBackend
and all built-in backends (and related code) to provide async logicRemoteUser
middleware to take advantage of the new async-native logicEach item above is a separate commit below, for easier convenience in reviewing. If requested, I'm happy to split this PR up into multiple PRs or combine commits.
Checklist
main
branch.