Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #25947 -- Query's str() method worked normally when 'default' database is empty #18039

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jayvynl
Copy link

@jayvynl jayvynl commented Apr 2, 2024

sql_with_params, build_lookup and is_nullable in Query would use the correct connection and generate more reasonable SQL.

Trac ticket number

ticket-25947

Branch description

This fix makes output of print(queryset.query) more reasonable when the queryset use a different database from default.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • For UI changes, I have attached screenshots in both light and dark modes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

…atabase is empty.

`sql_with_params`, `build_lookup` and `is_nullable` in `Query` would use the correct connection and generate more reasonable SQL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant