Fixed #35359 -- Made autodetector add fields referenced by GeneratedField.expression before it. #18068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
Ticket #35359
Branch description
While adding a
GeneratedField
field along with a new field, theAddField
operations were being generated in the wrong order due to which it was breaking the migrations. TheAddField
operation for fields referenced byGeneratedField.expression
should be added before theGeneratedField
itself.My solution modifies the
_generate_added_field
method in the autodetector to check if a field is aGeneratedField
, then extract the referenced fields from.expression
and recursively call_generate_added_field
to addAddField
operation for the fields referenced by.expression
beforeGeneratedField
.Checklist
main
branch.