New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a high contrast mode to screenshot cases. #18080
Conversation
1ffa2fa
to
65035c4
Compare
Screenshots can be seen in the Artifacts here: https://github.com/django/django/actions/runs/8701792464/ Here are a couple of examples: This aims to aid the review process. |
Super cool 👍🏻 |
Hi @sarahboyce 👋🏻 Firstly, congratulations on your new role! 🥳 (Not crossed paths on any post or pull request recently, so sorry for being late to the party...) This is great - it'll be helpful to have something for high contrast mode. This brings me to the point - you've named this |
cdca435
to
e6b9442
Compare
Thank you very much 😊
|
FYI, I have added some screenshots in #17910 per @sarahboyce's suggestion. |
e6b9442
to
05b5d92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, nice addition ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a little suggestion to skip the test on non-Chrome browsers which will work without affecting other screenshot cases as we're duplicating the test method.
Also need to update the PR title; perhaps:
Added a high contrast mode to screenshot cases.
Thank you to Sarah Abderemane and Nick Pope for the reviews.
05b5d92
to
bfc2de1
Compare
Branch description
To extend our accessibility tests, added screenshots in forced-colors mode.
Checklist
main
branch.