Fixed #35405 -- Used @cached_property in FieldCacheMixin. #18101
+112
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
reviewed
Apr 25, 2024
adamchainz
force-pushed
the
ticket_35405
branch
from
a665863
to
424b695
Compare
nessita
reviewed
Apr 26, 2024
nessita
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Thank you @adamchainz for this work! I agree with Simon that the patch looks good but I think this also needs a few tests covering the deprecation paths/messages and how both the old method and new cached property work OK.
adamchainz
force-pushed
the
ticket_35405
branch
2 times, most recently
from
973f80f
to
86d51aa
Compare
|
I have added some tests specific to the mixin, including for the deprecation path. |
co-authored-by: Simon Charette <charette.s@gmail.com> co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35405
Branch description
Optimization as described on ticket.
Checklist
mainbranch.