Fixed #35408 -- Optimized post-migrate permission creation. #18105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Apr 26, 2024
adamchainz
force-pushed
the
ticket_35408
branch
2 times, most recently
from
2fda5fa
to
ba10093
Compare
adamchainz
commented
Apr 26, 2024
Comment on lines
+49
to
+54
| try: | ||
| Permission = apps.get_model("auth", "Permission") | ||
| except LookupError: | ||
| return | ||
| if not router.allow_migrate_model(using, Permission): | ||
| return |
There was a problem hiding this comment.
Moved up here to early return before the extra call to create_contenttypes
David-Wobrock
approved these changes
Apr 26, 2024
felixxm
reviewed
Apr 26, 2024
adamchainz
force-pushed
the
ticket_35408
branch
2 times, most recently
from
4bf2c75
to
8b34ffa
Compare
sarahboyce
approved these changes
May 10, 2024
co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
|
Just pushed a fix because I realized I hadn’t actually removed the second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35408
Branch description
See ticket.
Checklist
mainbranch.