Add support for Perl(PCRE) named and unnamed group capturing order #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other words maintain the order of capture groups.
|
Thanks for submitting this! It'll take me a bit to review and gather my thoughts on it. |
dlclark
reviewed
May 13, 2021
| @@ -386,7 +417,11 @@ func (p *parser) countCaptures() error { | |||
| } | |||
| } else { | |||
| if !p.useOptionN() && !p.ignoreNextParen { | |||
| p.noteCaptureSlot(p.consumeAutocap(), pos) | |||
| if p.useMaintainCaptureOrder() { | |||
| p.noteCaptureName(fmt.Sprint(p.autocap), pos) | |||
There was a problem hiding this comment.
Because consumeAutocap is called inside noteCaptureName when MaintainCaptureOrder is enabled.
Does this need a comment somewhere?
- Document MaintainCaptureOrder option - Use return in `assignNameSlots` and remove else - Add test with MaintainCaptureOrder not provided - Change the MaintainCaptureOrder value to `0x0400` - Remove the `o` inline option - Add comment to explain why `autocap` is consumed
|
Is there anyway get named group？ like I want get |
|
@yywing Don't know why you asked that question here, as it's not relevant to the pull request. But you can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other words maintain the order of capture groups. With the
MaintainCaptureOrderregexp option.I also added inline option
o. It's useful if you only have access to the pattern, but not the regex. But it only is useful if used at the start of the pattern, I couldn't find a way to prevent it from being used elsewhere.I've never liked nor have been good with bitwise operations. So I don't know if I should've picked another number.