Update dependencies and documentation #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelLangbein
approved these changes
May 19, 2022
| @@ -94,7 +94,7 @@ jobs: | |||
| path: dist | |||
| - uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: 15 | |||
| node-version: 16 | |||
There was a problem hiding this comment.
Cool thing that we're moving up to node16. I think I remember that older versions of node/npm would create an old-style package-lock v1.
There was a problem hiding this comment.
Yes I think this was between npm 6 and 7.
We only have one Issue to fix for the publish step #129 where we use npm 6. But we don't install anything here, it's just for the publish command so I hope this is still working with the newer node version.
projects/core-ui/README.md
Outdated
| @@ -78,15 +78,15 @@ main-container | |||
| content-area | |||
| ``` | |||
|
|
|||
| and be aware that the router is placing the routes outside of the router-outlet (so they are not childs) | |||
| and keep in mind that the router is placing the routes outside of the router-outlet (so they are not childs) | |||
There was a problem hiding this comment.
... (so they are not children)
lucas-angermann
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Update to Angular v13 should be made.
What is the new behavior?
@dlr-eoc/core-uischematics and addskipLibCheckonng-addto tsconfig 55e7700, 5f146b4, 68abb5b@dlr-eoc/user-infoforAbstractControlfromFormGroup83549dfOffscreenCanvasindemo-maps,demo-auth, '@dlr-eoc/map-ol',@dlr-eoc/map-three,@dlr-eoc/map-toolsand@dlr-eoc/utils-maps33be2feDoes this PR introduce a breaking change?
Update Angular to
v13and ol-mapbox-style tov8Other information
Is it part of one/more packages and which?
@dlr-eocdue to Angular update