Skip to content

Commit

Permalink
docs(contributing): specify Chromium version format for releases (pup…
Browse files Browse the repository at this point in the history
…peteer#6956)

Co-authored-by: Mathias Bynens <mathias@qiwi.be>
  • Loading branch information
theDavidBarton and mathiasbynens committed Mar 31, 2021
1 parent b349c91 commit 30c7b3c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Expand Up @@ -264,11 +264,12 @@ The following steps are needed to update the Chromium version.
Not all revisions have builds for all platforms, so we need to find one that does.
To do so, run `utils/check_availability.js -rb` to find the latest suitable beta Chromium revision (see `utils/check_availability.js -help` for more options).
1. Update `src/revisions.ts` with the found revision number.
1. Update `versions.js` with the new Chromium-to-Puppeteer version mapping.
1. Run `npm run ensure-correct-devtools-protocol-revision`.
If it fails, update `package.json` with the expected `devtools-protocol` version.
1. Run `npm run tsc` and `npm install` and ensure that all tests pass. If a test fails, [bisect](#bisecting-upstream-changes) the upstream cause of the failure, and either update the test expectations accordingly (if it was an intended change) or work around the changes in Puppeteer (if it’s not desirable to change Puppeteer’s observable behavior).
1. Update `versions.js` with the new Chromium-to-Puppeteer version mapping.
1. Commit and push your changes and open a pull request.
1. Commit and push your changes and open a pull request.
The commit message must contain the version in `Chromium <version> (<revision>)` format to ensure that [pptr.dev](https://pptr.dev/) can parse it correctly, e.g. `'feat(chromium): roll to Chromium 90.0.4427.0 (r856583)'`.

### Bisecting upstream changes

Expand Down

0 comments on commit 30c7b3c

Please sign in to comment.