Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TinyProtocol for 1.19+ #2499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed TinyProtocol for 1.19+ #2499

wants to merge 1 commit into from

Conversation

gamerover98
Copy link

Fix #2497

@Bobcat00
Copy link

I can confirm this PR is needed to use TinyProtocol on 1.20.4. Someone should approve and merge this.

@derklaro
Copy link
Contributor

This doesn't fix TinyProtocol, this just fixes your use-case... TinyProtocol isn't maintained atm, and reviving it would require to update ALL packet types, not just one.

@CJCrafter
Copy link

This doesn't fix TinyProtocol, this just fixes your use-case... TinyProtocol isn't maintained atm, and reviving it would require to update ALL packet types, not just one.

What do you mean by use-case here? To my understanding, TinyProtocol doesn't use packet types. Instead, it intercepts the "raw" nms packets and forces you to handle the version specific code. This PR definitely fixes that in recent versions (though my testing was done quite a few versions ago).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJCrafter CJCrafter CJCrafter approved these changes

@itz-rj-here itz-rj-here itz-rj-here approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GameProfile field not found in TinyProtocol
5 participants
@gamerover98 @Bobcat00 @derklaro @CJCrafter @itz-rj-here