on error, report which cassette was not found #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: requested cassette not found After: requested cassette not found: FILENAME There is a caveat: this change tries to be as backwards compatible as possible, but, as the change in recorder_test.go shows, it breaks direct (!=) comparison with the sentinel error. On the other hand, one could argue that sentinel errors should always be compared with errors.Is(). In case you are not comfortable accepting this PR, no problems! Thanks for go-vcr, everybody I show it to starts using it :-)
|
@marco-m , LGTM, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v3 #89 +/- ##
=======================================
Coverage 77.69% 77.69%
=======================================
Files 1 1
Lines 278 278
=======================================
Hits 216 216
Misses 48 48
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
There is a caveat: this change tries to be as backwards compatible as possible, but, as the change in
recorder_test.goshows, it breaks direct (!=) comparison with the sentinel error. On the other hand, one could argue that sentinel errors should always be compared witherrors.Is()...In case you are not comfortable accepting this PR, no problems!
Thanks for go-vcr, everybody I show it to starts using it :-)