Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DatePicker): Convert to functional components with typescript and hooks (WIP) #2799

Draft
wants to merge 80 commits into
base: main
Choose a base branch
from
Draft

feat(DatePicker): Convert to functional components with typescript and hooks (WIP) #2799

wants to merge 80 commits into from
+3,819 −3,746

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Oct 26, 2023 •
edited

WIP

  • DatePicker
  • DatePickerAddon
  • DatePickerCalc
  • DatePickerCalendar
  • DatePickerContext
  • DatePickerFooter
  • DatePickerInput
  • DatePickerProvider
  • DatePickerRange
  • Fix tests
  • Fix types
  • Fix onClickOutside functionality
  • Make tests for onClickOutside
  • Fix DatePickerProvider getDerivedStateFromProps logic
  • Fix DatePickerInput mask and value logic
  • Fix DatePickerInput paste functionality
  • General Bugfixes
  • Move provider date logic to hook
  • Move provider view logic to hook
  • Move date correction logic closer to trigger
  • Move lastEventCallCache to hook
  • Fix callOnChangeHandler callback functionality
  • Fix Input onChange handling
  • Wrap necessary functions or values in useCallback or useMemo hooks
  • Remove locale prop, and depricate (Solved by only importing the two relevant functions used by the Locale object)
  • Replace all any types with more accurate ones
  • Fix Range Keyboard functionality
  • Clean up mess 🙏
  • fix type errors

@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 1:03pm

@joakbjerk joakbjerk changed the title chore(DatePicker): Convert to functional components with typescript adn hooks chore(DatePicker): Convert to functional components with typescript and hooks Oct 26, 2023
@joakbjerk joakbjerk changed the title chore(DatePicker): Convert to functional components with typescript and hooks chore(DatePicker): Convert to functional components with typescript and hooks (WIP) Dec 19, 2023
@tujoworker tujoworker changed the title chore(DatePicker): Convert to functional components with typescript and hooks (WIP) feat(DatePicker): Convert to functional components with typescript and hooks (WIP) Dec 19, 2023
@tujoworker tujoworker mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joakbjerk