feat(HelpButton): Add inline display variant #2857
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sundfjord
force-pushed
the
feat/help-button-inline
branch
from
fb56d7c
to
84f1970
Compare
Sundfjord
force-pushed
the
feat/help-button-inline
branch
from
84f1970
to
f04ac8c
Compare
tujoworker
force-pushed
the
feat/help-button-inline
branch
from
f04ac8c
to
87bc139
Compare
Sundfjord
force-pushed
the
feat/help-button-inline
branch
from
87bc139
to
4f15024
Compare
…e id prop in FieldHelpProps, and update docs accordingly
…h this test case and generate all snapshots for UI and Sbanken themes
Sundfjord
force-pushed
the
feat/help-button-inline
branch
from
4f15024
to
5ede82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a new variant of the
HelpButtoncomponent, that displays its contents in an inline element, as so:The help content container will by default be appended to the HelpButton instance's parent element, but a
contentIdmay also be specified to place the help content container in any existing DOM element.In addition to the necessary changes in the
HelpButtoncomponent,FormLabelnow accepts a newhelpprop which will by default display what is sent with thecontentsprop in an inline help button. The changes to the component are mainly done to ensure correct positioning of both the help button itself and its contents regardless of label direction.Test cases have been added for this new variant.