feat(Tabs): rewrite to TypeScript (WIP) #3065
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tujoworker
force-pushed
the
fix/tabs-content
branch
from
17e589e
to
ece87f8
Compare
tujoworker
force-pushed
the
fix/tabs-content
branch
2 times, most recently
from
a723cf7
to
3fbce1d
Compare
3 tasks
Not documented as of now. But the intention is to replace `validateDOMAttributes` with this new method.
tujoworker
force-pushed
the
fix/tabs-content
branch
from
3fbce1d
to
616bb13
Compare
tujoworker
added a commit
that referenced
this pull request
Apr 5, 2024
Removing EventEmitter is still left, as it is used in Tabs. But when #3065 lands, it should use `useSharedState` and we can then remove the EventEmitter entirely. --------- Co-authored-by: Ådne Rosenvinge <41082005+AadneRo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.