Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): add Field.Indeterminate #3513

Merged
merged 3 commits into from
May 14, 2024

Conversation

tujoworker
Copy link
Member

No description provided.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:19pm

Copy link

codesandbox-ci bot commented Apr 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch from df672e0 to 8d5cd35 Compare May 1, 2024 19:17
@tujoworker tujoworker marked this pull request as ready for review May 1, 2024 19:17
@tujoworker tujoworker changed the title feat(forms): add indeterminate support to Toggle and Boolean fields feat(forms): add Field.Indeterminate field May 1, 2024
@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch from 8d5cd35 to d1be70b Compare May 1, 2024 20:48
@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch from d1be70b to a54df40 Compare May 1, 2024 20:58
@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch 4 times, most recently from 77e01cb to 49837e4 Compare May 2, 2024 11:25
@tujoworker tujoworker requested a review from AadneRo May 2, 2024 11:26
@tujoworker tujoworker requested a review from joakbjerk May 3, 2024 09:42
@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch 2 times, most recently from 562548d to cde7fae Compare May 3, 2024 12:04
@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch from cde7fae to b056561 Compare May 10, 2024 09:18
@tujoworker tujoworker changed the title feat(forms): add Field.Indeterminate field feat(forms): add Field.Indeterminate May 14, 2024
@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch from b056561 to 6f0b028 Compare May 14, 2024 07:47
@tujoworker tujoworker force-pushed the feat/indeterminate-fields-support branch from 6f0b028 to 9f89c82 Compare May 14, 2024 07:54
@AadneRo
Copy link
Contributor

AadneRo commented May 14, 2024

Is this the functionality we want? I would expect the parent checkbox to uncheck all the children also

Screen.Recording.2024-05-14.at.12.48.04.mov

@tujoworker
Copy link
Member Author

Yeah, it should uncheck/toggle.

@tujoworker tujoworker merged commit 7e84a11 into main May 14, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/indeterminate-fields-support branch May 14, 2024 18:01
tujoworker pushed a commit that referenced this pull request May 15, 2024
## [10.31.0](v10.30.2...v10.31.0) (2024-05-15)

### 📝 Documentation

* **Checkbox:** update props to camelCase ([#3555](#3555)) ([22accc9](22accc9))

### 🐛 Bug Fixes

* **Drawer:** prevent `auto-focus` from triggering in inital mount when `openState` is `false` ([#3534](#3534)) ([07c741f](07c741f))
* **forms:** keep field props in memory during Wizard step change ([#3553](#3553)) ([02329dd](02329dd))
* **HeightAnimation:** set width during height calculation ([#3557](#3557)) ([8e59eaf](8e59eaf))

### ✨ Features

* **Checkbox:** add indeterminate state ([#3515](#3515)) ([d1ba274](d1ba274))
* **forms:** add `required` prop to Wizard.Step ([#3556](#3556)) ([fbb47e4](fbb47e4))
* **forms:** add Field.Indeterminate ([#3513](#3513)) ([7e84a11](7e84a11))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants