Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): keep field props in memory during Wizard step change #3553

Merged
merged 1 commit into from
May 14, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented May 13, 2024

In order to be able to filter data based in field props, this PR keeps unmounted field props in memory during step changes.

@tujoworker tujoworker requested a review from joakbjerk May 13, 2024 14:14
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 7:36am

Copy link

codesandbox-ci bot commented May 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker changed the title feat(forms): keep field props in memory during Wizard step change fix(forms): keep field props in memory during Wizard step change May 13, 2024
@tujoworker tujoworker merged commit 02329dd into main May 14, 2024
10 checks passed
@tujoworker tujoworker deleted the fix/keep-props-in-memory branch May 14, 2024 13:50
tujoworker pushed a commit that referenced this pull request May 15, 2024
## [10.31.0](v10.30.2...v10.31.0) (2024-05-15)

### 📝 Documentation

* **Checkbox:** update props to camelCase ([#3555](#3555)) ([22accc9](22accc9))

### 🐛 Bug Fixes

* **Drawer:** prevent `auto-focus` from triggering in inital mount when `openState` is `false` ([#3534](#3534)) ([07c741f](07c741f))
* **forms:** keep field props in memory during Wizard step change ([#3553](#3553)) ([02329dd](02329dd))
* **HeightAnimation:** set width during height calculation ([#3557](#3557)) ([8e59eaf](8e59eaf))

### ✨ Features

* **Checkbox:** add indeterminate state ([#3515](#3515)) ([d1ba274](d1ba274))
* **forms:** add `required` prop to Wizard.Step ([#3556](#3556)) ([fbb47e4](fbb47e4))
* **forms:** add Field.Indeterminate ([#3513](#3513)) ([7e84a11](7e84a11))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants