Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy, dependencies bump, readme fixes #335

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

virtualritz
Copy link

  • Ran clippy --fix, some manual reverts, see (clippy#11461).
  • Bumped dependencies where possible w/o code changes.
  • Fixed the Markdown files (MD syntax, headline capitalization, typography, grammar).

@virtualritz
Copy link
Author

P.S.: thank you for this great tool!!!

@cytrinox
Copy link
Contributor

Thanks for your contribution @virtualritz.
Please strip out clippy fixes, as they make some code lines less readable, thanks.

@virtualritz
Copy link
Author

virtualritz commented Sep 25, 2023

Please strip out clippy fixes, as they make some code lines less readable, thanks.

I think these came probably from cargo fmt, not clippy --fix. Can you tell me which ones (an example is enough)?

I would then rather add more rustfmt.toml settings that guarantee that cargo fmt generates formatting that you like.

On that note: most crates I contributed to in the last year now make running cargo fmt mandatory before submitting a PR, so I just do that out of habit now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants