Make DNG opcode lists available from rawler (fixed) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started experimenting with the opcode list processing here: https://github.com/paolodepetrillo/dnglab/tree/opcode-list-decode It doesn't actually apply any processing yet, but as of now it decodes all of the opcodes defined in DNG spec 1.7 and prints them out at the point in the develop process where they would be applied. |
|
bump. any interest in merging this? i'm using a version of this work with some merge conflicts resolved you can find it here to process gainmaps in vkdt (also based on @paolodepetrillo 's work). this can make quite a difference: |
|
As the |
|
excellent, this sounds really good! will look into this way of doing things
then, thanks!
…On Fri, May 3, 2024, 19:17 Daniel Vogelbacher ***@***.***> wrote:
As the WellKnownIFD API introduced in #412
<#412> already provides direct
access to DNG opcodes, I think this PR is no longer necessary.
—
Reply to this email directly, view it on GitHub
<#398 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMAKKKZN46YBRJKGX4KJM3ZAPBCTAVCNFSM6AAAAABBVY4EESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGQ2DENJSGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to make the DNG OpcodeList tags available through the rawler API, so that they can be accessed from within vkdt to implement some opcode list processing for lens corrections.
It specifically gets the tags corresponding to the raw image, which might be in either Image or SubImage1, and ignores any OpcodeLists for preview / thumbnail images elsewhere in the file.