build: fix writing correct image ID with -q #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason why one can't make a docker tarball or load to Docker instance from remote driver. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Container driver wrote manifest digest that had a mismatch with --iidfile output. When --iidfile was set the --metadata-file was not written. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
commented
May 26, 2023
| @@ -90,7 +90,7 @@ func (d *Driver) Client(ctx context.Context) (*client.Client, error) { | |||
| func (d *Driver) Features() map[driver.Feature]bool { | |||
| return map[driver.Feature]bool{ | |||
| driver.OCIExporter: true, | |||
| driver.DockerExporter: false, | |||
| driver.DockerExporter: true, | |||
There was a problem hiding this comment.
I don't understand why this was false.
There was a problem hiding this comment.
👀 yeah, I'm not sure either. Looks like it didn't get caught in #1078, my bad.
|
This reminds me of #989 to set the correct digest when image is pushed with moby but the other way around for this case. |
jedevc
reviewed
May 26, 2023
Comment on lines
+104
to
+107
| if sb.Name() == "remote" { | ||
| // there is no Docker atm to load the image | ||
| outFlag += ",dest=" + targetDir + "/image.tar" | ||
| } |
There was a problem hiding this comment.
🎉 tests!
I think we should probably find a way to hook into the unsupportedFeatures property of buildkit's Backend implementation, so that we could expose the driver features there, so we could rework this using integration.CheckFeatureCompat(t, sb, driver.DockerExporter).
I'll open a tracking issue for this, I'll take a look after the release.
jedevc
approved these changes
May 26, 2023
crazy-max
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1828