-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: set record provenance in response #2280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
crazy-max
commented
Feb 23, 2024
crazy-max
force-pushed
the
provenance-metadata
branch
3 times, most recently
from
February 24, 2024 14:03
436f6c4
to
4a00e0f
Compare
crazy-max
force-pushed
the
provenance-metadata
branch
6 times, most recently
from
February 28, 2024 09:24
eb6347c
to
e0256b6
Compare
crazy-max
commented
Feb 28, 2024
dvdksn
reviewed
Feb 28, 2024
crazy-max
force-pushed
the
provenance-metadata
branch
from
February 28, 2024 12:25
e0256b6
to
16b5bf3
Compare
crazy-max
force-pushed
the
provenance-metadata
branch
from
February 29, 2024 11:45
4c1003b
to
6711c97
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
crazy-max
force-pushed
the
provenance-metadata
branch
6 times, most recently
from
March 8, 2024 08:51
a1e68ca
to
b3585e6
Compare
crazy-max
force-pushed
the
provenance-metadata
branch
2 times, most recently
from
March 15, 2024 13:40
44789a4
to
16b1506
Compare
crazy-max
force-pushed
the
provenance-metadata
branch
5 times, most recently
from
March 17, 2024 14:38
fd017d8
to
9e35c6d
Compare
crazy-max
force-pushed
the
provenance-metadata
branch
from
March 27, 2024 17:34
9e35c6d
to
ad85d2f
Compare
@tonistiigi Updated to strip |
crazy-max
force-pushed
the
provenance-metadata
branch
from
March 27, 2024 17:43
ad85d2f
to
f0b31ce
Compare
crazy-max
force-pushed
the
provenance-metadata
branch
from
April 9, 2024 11:00
f0b31ce
to
eba0b61
Compare
tonistiigi
reviewed
Apr 10, 2024
crazy-max
force-pushed
the
provenance-metadata
branch
3 times, most recently
from
April 10, 2024 19:05
4e034e5
to
29890fa
Compare
tonistiigi
reviewed
Apr 11, 2024
crazy-max
force-pushed
the
provenance-metadata
branch
3 times, most recently
from
April 11, 2024 07:37
5e29d4b
to
fde233d
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
provenance-metadata
branch
from
April 11, 2024 08:11
fde233d
to
2e2f9f5
Compare
tonistiigi
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up discussion with @tonistiigi
related to #1681
Previously we got
containerimage.buildinfo
in the metadata file butbuildinfo
has been removed in BuildKit 0.12 (moby/buildkit#3582): https://github.com/moby/buildkit/blob/master/docs/deprecated.md#build-informationThis was useful to see all sources that were used by the build with their exact versions and also the configuration that was passed to the build.
However with the provenance attestation supported since BuildKit v0.11, we have similar (and a "bit" more) information available.
With this change we set the provenance saved along the build record in the metadata file similar to
containerimage.buildinfo
that is namedbuildx.build.provenance
. Will set minimal provenance by default but can be customized using theBUILDX_METADATA_PROVENANCE
env var.md.json
md.json
md.json