Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(validate): split lint #2439

Merged
merged 1 commit into from May 1, 2024
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Apr 30, 2024

follow-up moby/buildkit#4829 (comment)

This generates a matrix for each platform for lint and lint-gopls targets. I think I will port the logic in "Matrix" step to a subaction similar to https://github.com/docker/bake-action?tab=readme-ov-file#list-targets.

Reduces build time for the whole pipeline from ~30m:

image

To ~6m30:

image

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

@tonistiigi

Needs to remove "validate (lint)" from required checks in branches protection settings for the repo:

image

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was also thinking that maybe it would make sense to run the lint target(s) for native arch first and then others in parallel only if first one passed. If linting already wrong for common files then not much point of even running the custom arch variants.

@tonistiigi tonistiigi merged commit 1d88c4b into docker:master May 1, 2024
102 checks passed
@crazy-max crazy-max deleted the ci-split-validate branch May 1, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants