Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry support #635

Merged
merged 2 commits into from
Jul 12, 2021
Merged

OpenTelemetry support #635

merged 2 commits into from
Jul 12, 2021

Conversation

tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Jun 16, 2021

Depends on:

docker run -d --name jaeger  -p 6831:6831/udp -p 16686:16686 jaegertracing/all-in-one
docker buildx create --driver-opt network=host --driver-opt image=moby/buildkit:master --driver-opt env.JAEGER_TRACE=localhost:6831

@tonistiigi tonistiigi added this to the v0.6.0 milestone Jun 23, 2021
@tonistiigi tonistiigi marked this pull request as ready for review July 3, 2021 04:49
@crazy-max
Copy link
Member

Just tested myself, works great.

image

Not related to this PR but I also encountered an issue that seems linked to moby/buildkit#2162: SendMsg called after CloseSend

79ec0a42e37a50928d8911c2682f691a.json.zip

@tonistiigi
Copy link
Member Author

@crazy-max Do you have a reproducer for this as haven't seen this myself. Not a blocker for this PR but create a tracking issue in Buildkit if you do.

@crazy-max
Copy link
Member

Yes I have a reproducer on a public repo. Will create an issue on BuildKit repo.

@crazy-max
Copy link
Member

crazy-max commented Jul 8, 2021

@tonistiigi Looks like it has been fixed, can't repro anymore with moby/buildkit:v0.9.0-rc1.

@morlay
Copy link
Collaborator

morlay commented Jul 9, 2021

Nice feature!

log with traceID and spanID will be better. moby/buildkit#2235

@tonistiigi
Copy link
Member Author

@crazy-max Might be flaky. Don't know any change in the past days.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@dhopkalo
Copy link

dhopkalo commented Aug 18, 2021

when i use docker context with remote SSH I also have the next error

docker buildx build .
...
[+] Building 0.0s (0/0)
WARN[0000] commandConn.CloseWrite: commandconn: failed to wait: signal: killed
WARN[0000] commandConn.CloseRead: commandconn: failed to wait: signal: killed
WARN[0000] commandConn.CloseWrite: commandconn: failed to wait: signal: killed
[+] Building 0.0s (0/0)
error: failed to get status: rpc error: code = Unavailable desc = connection error: desc = "transport: failed to write client preface: write |1: broken pipe"
74637 v0.6.1-docker /usr/local/lib/docker/cli-plugins/docker-buildx --debug buildx build --platform linux/amd64 .
github.com/moby/buildkit/client.(*Client).solve.func4
	/go/src/github.com/docker/buildx/vendor/github.com/moby/buildkit/client/solve.go:249
golang.org/x/sync/errgroup.(*Group).Go.func1
	/go/src/github.com/docker/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:57
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1371

only change that was done for this part of code is replacing opentracing to opentelemetry lib

https://github.com/tonistiigi/buildx/blame/9d884501186b2269d341df6a4242627a70715c46/vendor/github.com/moby/buildkit/client/solve.go#L96

but it somehow damaged this part for case when we use remote ssh docker context builder

https://github.com/tonistiigi/buildx/blame/9d884501186b2269d341df6a4242627a70715c46/vendor/github.com/moby/buildkit/client/solve.go#L249

#737

@tonistiigi
Copy link
Member Author

@bobrik @drefixs #741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants