Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildkit take2 #3237

Closed
wants to merge 4 commits into from
Closed

Conversation

thaJeztah
Copy link
Member

quick try to make #3232 work

@thaJeztah
Copy link
Member Author

Arf.. looks like this is causing issues; google/gnostic@896953e.

error: unable to create file OpenAPIv2/OpenAPIv2.pb.go: File exists
error: unable to create file OpenAPIv2/OpenAPIv2.proto: File exists
error: unable to create file OpenAPIv2/README.md: File exists
error: unable to create file OpenAPIv2/openapi-2.0.json: File exists
error: unable to create file OpenAPIv3/OpenAPIv3.go: File exists
error: unable to create file OpenAPIv3/OpenAPIv3.pb.go: File exists
error: unable to create file OpenAPIv3/OpenAPIv3.proto: File exists
error: unable to create file OpenAPIv3/README.md: File exists
error: unable to create file OpenAPIv3/openapi-3.0.json: File exists
error: unable to create file OpenAPIv3/schema-generator/3.0.0.md: File exists
error: unable to create file OpenAPIv3/schema-generator/3.0.1.md: File exists
error: unable to create file OpenAPIv3/schema-generator/README.md: File exists
error: unable to create file OpenAPIv3/schema-generator/main.go: File exists
fatal: Could not reset index file to revision '7c663266750e7d82587642f65e60bc4083f1f84e'.

@thaJeztah
Copy link
Member Author

thaJeztah commented Aug 9, 2021

And more errors currently;

/go/src/github.com/docker/cli/vendor/go.opentelemetry.io/proto/otlp/trace/v1/trace.pb.go:25:6: could not import go.opentelemetry.io/proto/otlp/common/v1 
/go/src/github.com/docker/cli/vendor/go.opentelemetry.io/proto/otlp/common/v1/common.pb.go:40:17: ProtoPackageIsVersion4 not declared by package proto)

Those should be because the version that was specified is too old (needs v1.4 or above; golang/protobuf@ae97035)

@thaJeztah
Copy link
Member Author

thaJeztah commented Aug 9, 2021

oh! this one is weird

/go/src/github.com/docker/cli/cli/command/image/build_buildkit.go:403:9: v declared but not used 

also

could not import go.opentelemetry.io/proto/otlp/collector/trace/v1
/go/src/github.com/docker/cli/vendor/go.opentelemetry.io/proto/otlp/collector/trace/v1/trace_service.pb.gw.go:164:132:
AssumeColonVerbOpt not declared by package runtime

Last one; runtime refers to github.com/grpc-ecosystem/grpc-gateway/runtime. Probably needs an update. https://github.com/moby/buildkit/blob/v0.9.0/vendor/modules.txt#L280 shows:

# github.com/grpc-ecosystem/grpc-gateway v1.16.0
github.com/grpc-ecosystem/grpc-gateway/internal
github.com/grpc-ecosystem/grpc-gateway/runtime
github.com/grpc-ecosystem/grpc-gateway/utilities

and

# github.com/grpc-ecosystem/go-grpc-middleware v1.2.0
github.com/grpc-ecosystem/go-grpc-middleware

Getting closer;

vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_httpbodyproto.go:4:2: cannot find package "google.golang.org/genproto/googleapis/api/httpbody" in any of:
	/go/src/github.com/docker/cli/vendor/google.golang.org/genproto/googleapis/api/httpbody (vendor tree)
	/usr/local/go/src/google.golang.org/genproto/googleapis/api/httpbody (from $GOROOT)
	/go/src/google.golang.org/genproto/googleapis/api/httpbody (from $GOPATH)
vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/fieldmask.go:10:2: cannot find package "google.golang.org/genproto/protobuf/field_mask" in any of:
	/go/src/github.com/docker/cli/vendor/google.golang.org/genproto/protobuf/field_mask (vendor tree)
	/usr/local/go/src/google.golang.org/genproto/protobuf/field_mask (from $GOROOT)
	/go/src/google.golang.org/genproto/protobuf/field_mask (from $GOPATH)

https://github.com/moby/buildkit/blob/v0.9.0/vendor/modules.txt#L280

# google.golang.org/genproto v0.0.0-20201110150050-8816d57aaa9a
google.golang.org/genproto/googleapis/api/httpbody
google.golang.org/genproto/googleapis/rpc/errdetails
google.golang.org/genproto/googleapis/rpc/status
google.golang.org/genproto/protobuf/field_mask

And closer;

#14 33.38 # github.com/docker/cli/vendor/go.opentelemetry.io/proto/otlp/collector/trace/v1
#14 33.38 vendor/go.opentelemetry.io/proto/otlp/collector/trace/v1/trace_service_grpc.pb.go:14:11: undefined: grpc.SupportPackageIsVersion7
#14 33.38 vendor/go.opentelemetry.io/proto/otlp/collector/trace/v1/trace_service_grpc.pb.go:68:35: undefined: grpc.ServiceRegistrar

https://github.com/moby/buildkit/blob/v0.9.0/vendor/modules.txt#L486

# google.golang.org/grpc v1.38.0

@thaJeztah thaJeztah force-pushed the update_buildkit_take2 branch 6 times, most recently from 0fe49ec to 9c73b72 Compare August 9, 2021 16:44
vendor.conf Outdated
github.com/xeipuuv/gojsonpointer 02993c407bfbf5f6dae44c4f4b1cf6a39b5fc5bb
github.com/xeipuuv/gojsonreference bd5ef7bd5415a7ac448318e64f11a24cd21e594b
github.com/xeipuuv/gojsonschema 82fcdeb203eb6ab2a67d0a623d9c19e5e5a64927 # v1.2.0
go.opentelemetry.io/contrib 91e5180ae03828601f705ac8e7fc3bd9e34dae6a # v0.21.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check if we need the fork for this; https://github.com/moby/buildkit/blob/v0.9.0/go.mod#L79-L83

Copy link
Member

@crazy-max crazy-max Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to use that fork

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #3237 (e2487f9) into master (56e5910) will not change coverage.
The diff coverage is n/a.

❗ Current head e2487f9 differs from pull request most recent head ae797e8. Consider uploading reports for the commit ae797e8 to get more accurate results

@@           Coverage Diff           @@
##           master    #3237   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         302      302           
  Lines       21764    21764           
=======================================
  Hits        12621    12621           
  Misses       8219     8219           
  Partials      924      924           

crazy-max and others added 3 commits September 6, 2021 11:17
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…8dfe

full diff: moby/buildkit@fc3c182...9b010e7

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants