-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial otel implementation #4940
Conversation
vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/marshal_jsonpb.go
Fixed
Show fixed
Hide fixed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4940 +/- ##
==========================================
- Coverage 61.19% 60.97% -0.22%
==========================================
Files 294 295 +1
Lines 20538 20625 +87
==========================================
+ Hits 12568 12576 +8
- Misses 7076 7154 +78
- Partials 894 895 +1 |
@jsternberg's PR #4889 just got merged 🥳 Can you rebase and see if everything's fine @krissetto? |
0a865b9
to
f0162c8
Compare
Just so I don't forget this, can you get code into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side I think this is good. I'll approve so long to revert my "requested changes" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳 looks like there's a couple of linting errors, but other than that I'm happy with the current state of the PR.
@jsternberg wanna take a final look? :') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments but this mostly looks good to me.
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
…testing purposes Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
- What's this?
OTEL bits in the CLI
- Goal
The very first goal is to provide enough metrics to cover the
compose wrapper
's current usage (so we can then remove it).To keep continuity with the current impl in the
compose wrapper
, these should include at minimum:Pls note that the organization of the code is not final and will surely be adjusted as the implementation matures
- What I did
- How I did it
Taking inspiration and adapting bits from
buildx
and thecompose wrapper
- How to verify it
Manually. Automated tests still need to be defined
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)