New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Run tests against the c8d image store #11046
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11046 +/- ##
==========================================
+ Coverage 56.20% 56.29% +0.09%
==========================================
Files 134 134
Lines 11564 11564
==========================================
+ Hits 6499 6510 +11
+ Misses 4421 4413 -8
+ Partials 644 641 -3 ☔ View full report in Codecov by Sentry. |
.github/workflows/ci.yml
Outdated
- | ||
name: Setup docker CLI | ||
run: | | ||
curl https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_CLI_VERSION}.tgz | tar xz | ||
sudo cp ./docker/docker /usr/bin/ && rm -rf docker && docker version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be overridden by crazy-max/ghaction-setup-docker
(24.0.6). See https://github.com/docker/compose/actions/runs/6338599258/job/17216038445?pr=11046#step:7:261
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info, that's fine
Added a job that will run e2e tests against a docker daemon that has the containerd-integration feature enabled. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
What I did
Added a job that will run e2e tests against a docker daemon that has the containerd-integration feature enabled.
Note: Adding this as a draft PR, I don't necessarily expect you to merge this one but I want to see what (if anything) fails with the containerd integration
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did