some commands don't need Dependencies being checked #11050
+42
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
project-ignore-dependencies
branch
from
0d914da
to
a38f8d5
Compare
ndeloof
commented
Oct 30, 2023
| @@ -311,7 +312,9 @@ func RootCommand(dockerCli command.Cli, backend api.Service) *cobra.Command { // | |||
| "commandConn.CloseRead:", | |||
| )) | |||
|
|
|||
| opts := ProjectOptions{} | |||
| opts := ProjectOptions{ | |||
| Dependencies: types.IncludeDependencies, | |||
There was a problem hiding this comment.
I wonder IgnoreDependencies should be the default value, and we opt-in for dependencies in up/start/stop/down commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
some commands like
docker compose logs SERVICEdon't have to validate dependencies are well defined in project modelRelated issue
fixes #10993
(not mandatory) A picture of a cute animal, if possible in relation to what you did