-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only use ToModel when --no-interpolate is set #11604
Conversation
b871254
to
835b62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add e2e tests to check both behaviours please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
835b62d
to
db3f61e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11604 +/- ##
==========================================
- Coverage 58.20% 57.73% -0.47%
==========================================
Files 135 138 +3
Lines 11611 11729 +118
==========================================
+ Hits 6758 6772 +14
- Misses 4182 4281 +99
- Partials 671 676 +5 ☔ View full report in Codecov by Sentry. |
Hey @ndeloof, great to see a fix. When are you planning to release it? |
I'll run a release tomorrow |
What I did
#11556 has impact on
compose config
which disturbs our users. This PR allows to preserve the previous behavior as long as--no-interpolate
isn't set, and only switch to raw model parsing when setWe can then work in parallel to get
ToModel
closer toToProject
until we can eventually remove duplicated code pathRelated issue
#11598
(not mandatory) A picture of a cute animal, if possible in relation to what you did