Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.10 backport] compose: bump version to v2.14.0 #790

Merged
merged 1 commit into from
Dec 4, 2022
Merged

[20.10 backport] compose: bump version to v2.14.0 #790

merged 1 commit into from
Dec 4, 2022

Conversation

milas
Copy link
Contributor

@milas milas commented Dec 2, 2022

@milas
compose: bump version to v2.14.0
c831eb9 
https://github.com/docker/compose/releases/tag/v2.14.0

(cherry picked from commit 66536b7)

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
glours
glours approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Dec 4, 2022 •
edited 

 > [linux/amd64->darwin/arm64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker:
#24 0.616 Building static docker-darwin-arm64
#24 69.79 # github.com/docker/cli/vendor/github.com/miekg/pkcs11
#24 69.79 cgo: malformed DWARF TagVariable entry

more logs;

+ SRC=src/github.com/docker/scan-cli-plugin
+ REF=v0.23.0
+ REF_FETCH=v0.23.0
+ git -C src/github.com/docker/scan-cli-plugin ls-remote --refs --heads --tags origin v0.23.0
+ awk {print $2}
+ REF=refs/tags/v0.23.0
+ [ -n refs/tags/v0.23.0 ]
+ REF_FETCH=refs/tags/v0.23.0:refs/tags/v0.23.0
+ git -C src/github.com/docker/scan-cli-plugin fetch --update-head-ok --depth 1 origin refs/tags/v0.23.0:refs/tags/v0.23.0
From https://github.com/docker/scan-cli-plugin
 * [new tag]         v0.23.0    -> v0.23.0
+ git -C src/github.com/docker/scan-cli-plugin checkout -q refs/tags/v0.23.0
for p in cross-mac; do \
	make -C static VERSION=0.0.1-dev GO_VERSION=1.18.8 TARGETPLATFORM= CONTAINERD_VERSION= RUNC_VERSION= ${p}; \
done
make[1]: Entering directory '/home/ubuntu/workspace/docker-ce-packaging_PR-790/static'
docker buildx inspect | grep -q 'Driver: docker-container' || docker buildx create --use
eager_ride
mkdir -p build/mac/amd64/docker
GOOS=darwin GOARCH=amd64 docker run --rm -e GOOS -e GOARCH -v "/home/ubuntu/workspace/docker-ce-packaging_PR-790/static/build/mac/amd64/docker/cli-plugins":/out -v "/home/ubuntu/workspace/docker-ce-packaging_PR-790/static/../plugins":/plugins:ro -v "/home/ubuntu/workspace/docker-ce-packaging_PR-790/static/scripts/build-cli-plugins":/build:ro golang:1.18.8 /build
Unable to find image 'golang:1.18.8' locally
1.18.8: Pulling from library/golang
a8ca11554fce: Pulling fs layer
e4e46864aba2: Pulling fs layer
c85a0be79bfb: Pulling fs layer
195ea6a58ca8: Pulling fs layer
52908dc1c386: Pulling fs layer
3cb762126a62: Pulling fs layer
9601c0a52d29: Pulling fs layer
195ea6a58ca8: Waiting
52908dc1c386: Waiting
3cb762126a62: Waiting
9601c0a52d29: Waiting
e4e46864aba2: Verifying Checksum
e4e46864aba2: Download complete
c85a0be79bfb: Verifying Checksum
c85a0be79bfb: Download complete
a8ca11554fce: Verifying Checksum
a8ca11554fce: Download complete
195ea6a58ca8: Verifying Checksum
195ea6a58ca8: Download complete
9601c0a52d29: Verifying Checksum
9601c0a52d29: Download complete
52908dc1c386: Verifying Checksum
52908dc1c386: Download complete
3cb762126a62: Verifying Checksum
3cb762126a62: Download complete
a8ca11554fce: Pull complete
e4e46864aba2: Pull complete
c85a0be79bfb: Pull complete
195ea6a58ca8: Pull complete
52908dc1c386: Pull complete
3cb762126a62: Pull complete
9601c0a52d29: Pull complete
Digest: sha256:0936e7443a0466cdad467ab8bafe6082999c065ebc389e7db22b0452d5d98842
Status: Downloaded newer image for golang:1.18.8
Cloning into '/go/src/github.com/docker/buildx'...
Fetching origin
+ GO111MODULE=on
+ go build -mod=vendor -o bin/docker-buildx -ldflags '-X github.com/docker/buildx/version.Version=v0.9.1-docker -X github.com/docker/buildx/version.Revision=ed00243a0ce2a0aee75311b06e32d33b44729689 -X github.com/docker/buildx/version.Package=github.com/docker/buildx' ./cmd/buildx
docker run --rm -v /home/ubuntu/workspace/docker-ce-packaging_PR-790/static:/v -w /v alpine chown -R 1000:1000 build/mac/amd64
Unable to find image 'alpine:latest' locally
latest: Pulling from library/alpine
c158987b0551: Pulling fs layer
c158987b0551: Verifying Checksum
c158987b0551: Download complete
c158987b0551: Pull complete
Digest: sha256:8914eb54f968791faf6a8638949e480fef81e697984fba772b3976835194c6d4
Status: Downloaded newer image for alpine:latest
mkdir -p build/mac/arm64/docker
GOOS=darwin GOARCH=arm64 docker run --rm -e GOOS -e GOARCH -v "/home/ubuntu/workspace/docker-ce-packaging_PR-790/static/build/mac/arm64/docker/cli-plugins":/out -v "/home/ubuntu/workspace/docker-ce-packaging_PR-790/static/../plugins":/plugins:ro -v "/home/ubuntu/workspace/docker-ce-packaging_PR-790/static/scripts/build-cli-plugins":/build:ro golang:1.18.8 /build
Cloning into '/go/src/github.com/docker/buildx'...
Fetching origin
+ GO111MODULE=on
+ go build -mod=vendor -o bin/docker-buildx -ldflags '-X github.com/docker/buildx/version.Version=v0.9.1-docker -X github.com/docker/buildx/version.Revision=ed00243a0ce2a0aee75311b06e32d33b44729689 -X github.com/docker/buildx/version.Package=github.com/docker/buildx' ./cmd/buildx
docker run --rm -v /home/ubuntu/workspace/docker-ce-packaging_PR-790/static:/v -w /v alpine chown -R 1000:1000 build/mac/arm64
cd /home/ubuntu/workspace/docker-ce-packaging_PR-790/src/github.com/docker/cli && VERSION=0.0.0-20221116174738-a60bf81 docker buildx bake --set binary.platform=darwin/amd64,darwin/arm64 binary
#1 [internal] booting buildkit
#1 pulling image moby/buildkit:buildx-stable-1
#1 pulling image moby/buildkit:buildx-stable-1 2.3s done
#1 creating container buildx_buildkit_eager_ride0
#1 creating container buildx_buildkit_eager_ride0 2.2s done
#1 DONE 4.5s

#2 [internal] load .dockerignore
#2 transferring context: 112B done
#2 DONE 0.1s

#3 [internal] load build definition from Dockerfile
#3 transferring dockerfile: 1.78kB done
#3 DONE 0.1s

#4 resolve image config for docker.io/docker/dockerfile:1
#4 ...

#5 [auth] docker/dockerfile:pull token for registry-1.docker.io
#5 DONE 0.0s

#4 resolve image config for docker.io/docker/dockerfile:1
#4 DONE 0.6s

#6 docker-image://docker.io/docker/dockerfile:1@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84ced81e24ef1a0dbc
#6 resolve docker.io/docker/dockerfile:1@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84ced81e24ef1a0dbc done
#6 sha256:1328b32c40fca9bcf9d70d8eccb72eb873d1124d72dadce04db8badbe7b08546 9.94MB / 9.94MB 0.2s
#6 sha256:1328b32c40fca9bcf9d70d8eccb72eb873d1124d72dadce04db8badbe7b08546 9.94MB / 9.94MB 0.4s done
#6 extracting sha256:1328b32c40fca9bcf9d70d8eccb72eb873d1124d72dadce04db8badbe7b08546
#6 extracting sha256:1328b32c40fca9bcf9d70d8eccb72eb873d1124d72dadce04db8badbe7b08546 0.2s done
#6 DONE 0.7s

#7 [darwin/arm64 internal] load metadata for docker.io/dockercore/golang-cross:xx-sdk-extras
#7 ...

#8 [auth] dockercore/golang-cross:pull token for registry-1.docker.io
#8 DONE 0.0s

#9 [auth] tonistiigi/xx:pull token for registry-1.docker.io
#9 DONE 0.0s

#10 [auth] library/golang:pull token for registry-1.docker.io
#10 DONE 0.0s

#11 [linux/amd64 internal] load metadata for docker.io/library/golang:1.18.8-alpine
#11 ...

#7 [darwin/arm64 internal] load metadata for docker.io/dockercore/golang-cross:xx-sdk-extras
#7 DONE 0.8s

#12 [darwin/amd64 internal] load metadata for docker.io/dockercore/golang-cross:xx-sdk-extras
#12 DONE 0.8s

#11 [linux/amd64 internal] load metadata for docker.io/library/golang:1.18.8-alpine
#11 DONE 0.9s

#13 [linux/amd64 internal] load metadata for docker.io/tonistiigi/xx:1.1.0
#13 DONE 0.9s

#14 FROM docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41
#14 resolve docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41 0.0s done
#14 DONE 0.1s

#15 [linux/amd64 xx 1/1] FROM docker.io/tonistiigi/xx:1.1.0@sha256:38b94c9b7d64f31544c9fd7a979fa856ab50b2b41cf35eee15d66088e8b5a06f
#15 resolve docker.io/tonistiigi/xx:1.1.0@sha256:38b94c9b7d64f31544c9fd7a979fa856ab50b2b41cf35eee15d66088e8b5a06f 0.1s done
#15 DONE 0.1s

#16 FROM docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41
#16 resolve docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41 0.0s done
#16 ...

#15 [linux/amd64 xx 1/1] FROM docker.io/tonistiigi/xx:1.1.0@sha256:38b94c9b7d64f31544c9fd7a979fa856ab50b2b41cf35eee15d66088e8b5a06f
#15 sha256:9b3b2510e20ad4453410e380667d4f482b9dc5f82e3023eb0c672b24ea624329 14.84kB / 14.84kB 0.1s done
#15 extracting sha256:9b3b2510e20ad4453410e380667d4f482b9dc5f82e3023eb0c672b24ea624329 0.0s done
#15 DONE 0.3s

#17 [linux/amd64 build-base-alpine 1/4] FROM docker.io/library/golang:1.18.8-alpine@sha256:d3984823081813d1f2b3939e9b5ae72ea14e3a886dd9e7726000bf68d23c231a
#17 resolve docker.io/library/golang:1.18.8-alpine@sha256:d3984823081813d1f2b3939e9b5ae72ea14e3a886dd9e7726000bf68d23c231a 0.0s done
#17 DONE 0.3s

#18 [internal] load build context
#18 transferring context: 22.38MB 2.2s
#18 transferring context: 50.40MB 3.6s done
#18 DONE 4.0s

#17 [linux/amd64 build-base-alpine 1/4] FROM docker.io/library/golang:1.18.8-alpine@sha256:d3984823081813d1f2b3939e9b5ae72ea14e3a886dd9e7726000bf68d23c231a
#17 sha256:0e2f191bfd4d74732a36d363f5f562db5bfcd7abb181dc7d1ed8ed0821e8fb4d 155B / 155B 0.4s done
#17 sha256:3111f9ab0f71a2e8782871bdf71a3f059e7714d32b7f0c91fe3b33f4cb048dc3 115.37MB / 115.37MB 3.5s done
#17 sha256:c158987b05517b6f2c5913f3acef1f2182a32345a304fe357e3ace5fadcad715 3.37MB / 3.37MB 0.5s done
#17 sha256:019cfb932eb08a6864463dc9a70bd1b3370081e9053b80029691335a239edb4c 284.81kB / 284.81kB 0.2s done
#17 extracting sha256:c158987b05517b6f2c5913f3acef1f2182a32345a304fe357e3ace5fadcad715 1.0s done
#17 extracting sha256:019cfb932eb08a6864463dc9a70bd1b3370081e9053b80029691335a239edb4c 0.3s done
#17 DONE 4.0s

#16 FROM docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41
#16 sha256:349cb1bd3798629cf55586b8042e6ad51b79f6f3f3116237f6ef5382a3d1c6e8 151.10MB / 151.10MB 3.8s
#16 sha256:349cb1bd3798629cf55586b8042e6ad51b79f6f3f3116237f6ef5382a3d1c6e8 151.10MB / 151.10MB 4.8s done
#16 extracting sha256:349cb1bd3798629cf55586b8042e6ad51b79f6f3f3116237f6ef5382a3d1c6e8
#16 ...

#17 [linux/amd64 build-base-alpine 1/4] FROM docker.io/library/golang:1.18.8-alpine@sha256:d3984823081813d1f2b3939e9b5ae72ea14e3a886dd9e7726000bf68d23c231a
#17 extracting sha256:3111f9ab0f71a2e8782871bdf71a3f059e7714d32b7f0c91fe3b33f4cb048dc3 7.2s done
#17 extracting sha256:0e2f191bfd4d74732a36d363f5f562db5bfcd7abb181dc7d1ed8ed0821e8fb4d 0.2s done
#17 DONE 11.4s

#19 [linux/amd64 build-base-alpine 2/4] COPY --from=xx / /
#19 ...

#16 FROM docker.io/dockercore/golang-cross:xx-sdk-extras@sha256:9ac9641111aeb58ce39b1e7423f80dd08af0e05d1c9fa38725f6ee37a1573b41
#16 extracting sha256:349cb1bd3798629cf55586b8042e6ad51b79f6f3f3116237f6ef5382a3d1c6e8 18.9s done
#16 DONE 23.9s

#19 [linux/amd64 build-base-alpine 2/4] COPY --from=xx / /
#19 DONE 14.2s

#20 [linux/amd64 build-base-alpine 3/4] RUN apk add --no-cache clang lld llvm file git
#20 0.174 fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/main/x86_64/APKINDEX.tar.gz
#20 1.476 fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/community/x86_64/APKINDEX.tar.gz
#20 1.848 (1/21) Installing libffi (3.4.4-r0)
#20 1.851 (2/21) Installing libgcc (12.2.1_git20220924-r4)
#20 1.862 (3/21) Installing libstdc++ (12.2.1_git20220924-r4)
#20 1.890 (4/21) Installing xz-libs (5.2.9-r0)
#20 1.895 (5/21) Installing libxml2 (2.10.3-r1)
#20 1.953 (6/21) Installing zstd-libs (1.5.2-r9)
#20 1.968 (7/21) Installing llvm15-libs (15.0.6-r0)
#20 3.499 (8/21) Installing clang15-libs (15.0.6-r0)
#20 4.188 (9/21) Installing libstdc++-dev (12.2.1_git20220924-r4)
#20 4.628 (10/21) Installing clang15 (15.0.6-r0)
#20 4.735 (11/21) Installing libmagic (5.43-r0)
#20 4.776 (12/21) Installing file (5.43-r0)
#20 4.779 (13/21) Installing brotli-libs (1.0.9-r9)
#20 4.796 (14/21) Installing nghttp2-libs (1.51.0-r0)
#20 4.801 (15/21) Installing libcurl (7.86.0-r1)
#20 4.813 (16/21) Installing libexpat (2.5.0-r0)
#20 4.818 (17/21) Installing pcre2 (10.40-r0)
#20 4.831 (18/21) Installing git (2.38.1-r0)
#20 4.930 (19/21) Installing lld-libs (15.0.6-r0)
#20 4.998 (20/21) Installing lld (15.0.6-r0)
#20 5.002 (21/21) Installing llvm15 (15.0.6-r0)
#20 5.662 Executing busybox-1.35.0-r29.trigger
#20 5.669 OK: 346 MiB in 37 packages
#20 DONE 11.9s

#21 [linux/amd64 build-base-alpine 4/4] WORKDIR /go/src/github.com/docker/cli
#21 DONE 0.0s

#22 [linux/amd64->darwin/arm64 build-alpine 1/1] RUN xx-apk add --no-cache musl-dev gcc
#22 0.114 skipping packages installation on darwin
#22 DONE 0.1s

#23 [linux/amd64->darwin/amd64 build-alpine 1/1] RUN xx-apk add --no-cache musl-dev gcc
#0 0.111 skipping packages installation on darwin
#23 DONE 0.1s

#24 [linux/amd64->darwin/arm64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker
#24 0.616 Building static docker-darwin-arm64
#24 ...

#25 [linux/amd64->darwin/amd64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker
#0 0.651 Building static docker-darwin-amd64
#25 69.80 # github.com/docker/cli/vendor/github.com/miekg/pkcs11
#25 69.80 cgo: malformed DWARF TagVariable entry
#25 ...

#24 [linux/amd64->darwin/arm64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker
#24 69.79 # github.com/docker/cli/vendor/github.com/miekg/pkcs11
#24 69.79 cgo: malformed DWARF TagVariable entry
#24 ...

#25 [linux/amd64->darwin/amd64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker
#25 ERROR: process "/bin/sh -c xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ \"$GO_LINKMODE\" = \"static\" ] && echo \"--static\") /out/docker" did not complete successfully: exit code: 2

#24 [linux/amd64->darwin/arm64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker
#24 ERROR: process "/bin/sh -c xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ \"$GO_LINKMODE\" = \"static\" ] && echo \"--static\") /out/docker" did not complete successfully: exit code: 2
------
 > [linux/amd64->darwin/amd64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker:
#0 0.651 Building static docker-darwin-amd64
#25 69.80 # github.com/docker/cli/vendor/github.com/miekg/pkcs11
#25 69.80 cgo: malformed DWARF TagVariable entry
------
------
 > [linux/amd64->darwin/arm64 build 1/1] RUN --mount=ro --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker:
#24 0.616 Building static docker-darwin-arm64
#24 69.79 # github.com/docker/cli/vendor/github.com/miekg/pkcs11
#24 69.79 cgo: malformed DWARF TagVariable entry
------
Dockerfile:39
--------------------
  38 |     ARG VERSION
  39 | >>> RUN --mount=ro --mount=type=cache,target=/root/.cache \
  40 | >>>     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk \
  41 | >>>     --mount=type=tmpfs,target=cli/winresources \
  42 | >>>     xx-go --wrap && \
  43 | >>>     # export GOCACHE=$(go env GOCACHE)/$(xx-info)$([ -f /etc/alpine-release ] && echo "alpine") && \
  44 | >>>     TARGET=/out ./scripts/build/binary && \
  45 | >>>     xx-verify $([ "$GO_LINKMODE" = "static" ] && echo "--static") /out/docker
  46 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ \"$GO_LINKMODE\" = \"static\" ] && echo \"--static\") /out/docker" did not complete successfully: exit code: 2
make[1]: *** [Makefile:71: cross-mac] Error 1
make[1]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-790/static'
make: *** [Makefile:89: static] Error 2
script returned exit code 2

Hmm. Looks like we're running into the same issue as with BuildKit; moby/moby#44570

It's a bug / incompatibility in Go with newer versions of LLVM. I opened a backport in Go for Go 1.18, but that won't make it in until go1.18.10 (go1.18.9 will be a security release) In the meantime we should pin the alpine version to 3.16, similar to moby/buildkit#3353

See

Let me look at that.

@thaJeztah thaJeztah changed the title compose: bump version to v2.14.0 [20.10 backport] compose: bump version to v2.14.0 Dec 4, 2022
This was referenced Dec 4, 2022
Merged
Merged
@thaJeztah
Copy link
Member

Opened;

@thaJeztah
Copy link
Member

All green now, with the fixes / workaround merged in docker/cli 🎉

thaJeztah
thaJeztah approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 7ff4746 into docker:20.10 Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milas @thaJeztah @glours