Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: louder notice about sles being s390x only #20041

Merged
merged 1 commit into from
May 17, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented May 15, 2024

The SLES installation instruction has gotten a low CSAT score, likely because it's only for the s390x architecture, and people are mistakingly assuming it works for x86. I amplified the notice about this instruction being applicable only for s390x/IBM Z mainframes.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product labels May 15, 2024
Copy link

netlify bot commented May 15, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit c4a09ff
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6644c33e3ceac1000873133a
😎 Deploy Preview https://deploy-preview-20041--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thaJeztah
Copy link
Member

thaJeztah commented May 15, 2024

LOL; IBM for sure has been around for a couple of years now.
Screenshot 2024-05-15 at 17 57 08

@dvdksn dvdksn requested a review from a team May 15, 2024 17:05
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a tiny comment ✨

content/engine/install/sles.md Show resolved Hide resolved
@dvdksn dvdksn merged commit f187699 into docker:main May 17, 2024
10 checks passed
@dvdksn dvdksn deleted the sles-clarify-s390x branch May 17, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon area/install Relates to installing a product status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants