Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake: set cwd:// prefix for bake files path #370

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

crazy-max
Copy link
Member

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit 41e1fe3 into docker:master Jan 4, 2024
30 checks passed
@crazy-max crazy-max deleted the bake-cwd branch January 4, 2024 19:49
renovate bot added a commit to 4m-mazi/gh-test that referenced this pull request Jan 5, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [docker/metadata-action](https://togithub.com/docker/metadata-action)
| action | minor | `v5.4.0` -> `v5.5.0` |

---

### Release Notes

<details>
<summary>docker/metadata-action (docker/metadata-action)</summary>

###
[`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0)

- Set `cwd://` prefix for bake files path by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#370
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.16.0 to 0.16.1 in
[docker/metadata-action#371
- Bump moment from 2.29.4 to 2.30.1 in
[docker/metadata-action#373
- Bump moment-timezone from 0.5.43 to 0.5.44 in
[docker/metadata-action#374

**Full Changelog**:
docker/metadata-action@v5.4.0...v5.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Mogyuchi/gh-test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
arnfinn pushed a commit to Rapporteket/docker that referenced this pull request Jan 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [docker/metadata-action](https://togithub.com/docker/metadata-action)
| action | minor | `v5.4.0` -> `v5.5.0` |

---

### Release Notes

<details>
<summary>docker/metadata-action (docker/metadata-action)</summary>

###
[`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0)

- Set `cwd://` prefix for bake files path by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#370
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.16.0 to 0.16.1 in
[docker/metadata-action#371
- Bump moment from 2.29.4 to 2.30.1 in
[docker/metadata-action#373
- Bump moment-timezone from 0.5.43 to 0.5.44 in
[docker/metadata-action#374

**Full Changelog**:
docker/metadata-action@v5.4.0...v5.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Rapporteket/docker).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@olee
Copy link

olee commented Jan 25, 2024

I don't know why, but this change seems to break some builds - and that quite inconsistently.
In my case I have a matrix build and it actually happened to me, that one of the meta files was generated with cwd:// in the path which caused that one to fail, whereas another one didn't get the cwd and ran just fine:

Matrix job 1 generates this command:
/usr/bin/docker buildx bake --file docker-compose.yaml --file docker-compose.bake.yaml --file docker-bake.gha.hcl --file cwd:///home/runner/work/_temp/docker-actions-toolkit-A8BM8v/docker-metadata-action-bake.json --metadata-file /home/runner/work/_temp/docker-actions-toolkit-oxkS5j/metadata-file --pull --push gha_keycloak-config --print

Matrix job 2 generates this command:
/usr/bin/docker buildx bake --file docker-compose.prod.yaml --file docker-compose.bake.yaml --file docker-bake.gha.hcl --file /home/runner/work/_temp/docker-actions-toolkit-bsKuk7/docker-metadata-action-bake.json --metadata-file /home/runner/work/_temp/docker-actions-toolkit-dPbXcm/metadata-file --pull --push gha_migration-runner --print

Both seem to load the file, but for some reason it seems that in the case with cwd:// the file is interpreted before the other specified bake files instead of afterwards.

I notice this because in docker-bake.gha.hcl I have target "docker-metadata-action" { tags = ["!tag-not-set!"] } which will cause to build to fail if not overwritten.
When cwd:// is present in the path, this tag is not overwritten, but if the path is without cwd it works just fine.

Any idea what could be causing this or is there any way to remove that prefix?

@crazy-max
Copy link
Member Author

@olee

which caused that one to fail, whereas another one didn't get the cwd and ran just fine:

The change of behavior might be related to GitHub slowly provisioning runners with latest Docker 25 which now installs Buildx 0.12. Can you open an issue with your workflow, logs and link to your repo if possible to take a look?

I notice this because in docker-bake.gha.hcl I have target "docker-metadata-action" { tags = ["!tag-not-set!"] } which will cause to build to fail if not overwritten.
When cwd:// is present in the path, this tag is not overwritten, but if the path is without cwd it works just fine.

Hum that doesn't sound right indeed. It should merge files in the specified order. Can you open another issue on https://github.com/docker/buildx this time with a minimal repro?

paddatrapper added a commit to libretime/libretime that referenced this pull request Feb 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [docker/metadata-action](https://togithub.com/docker/metadata-action)
| action | minor | `v5.4.0` -> `v5.5.1` |

---

### Release Notes

<details>
<summary>docker/metadata-action (docker/metadata-action)</summary>

###
[`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1)

- Don't set `cwd://` prefix for local bake files by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#382

**Full Changelog**:
docker/metadata-action@v5.5.0...v5.5.1

###
[`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0)

- Set `cwd://` prefix for bake files path by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#370
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.16.0 to 0.16.1 in
[docker/metadata-action#371
- Bump moment from 2.29.4 to 2.30.1 in
[docker/metadata-action#373
- Bump moment-timezone from 0.5.43 to 0.5.44 in
[docker/metadata-action#374

**Full Changelog**:
docker/metadata-action@v5.4.0...v5.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/libretime/libretime).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kyle Robbertze <kyle@paddatrapper.com>
jooola pushed a commit to mp3butcher/libretime that referenced this pull request Feb 2, 2024
…e#2928)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [docker/metadata-action](https://togithub.com/docker/metadata-action)
| action | minor | `v5.4.0` -> `v5.5.1` |

---

### Release Notes

<details>
<summary>docker/metadata-action (docker/metadata-action)</summary>

###
[`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1)

- Don't set `cwd://` prefix for local bake files by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#382

**Full Changelog**:
docker/metadata-action@v5.5.0...v5.5.1

###
[`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0)

- Set `cwd://` prefix for bake files path by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#370
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.16.0 to 0.16.1 in
[docker/metadata-action#371
- Bump moment from 2.29.4 to 2.30.1 in
[docker/metadata-action#373
- Bump moment-timezone from 0.5.43 to 0.5.44 in
[docker/metadata-action#374

**Full Changelog**:
docker/metadata-action@v5.4.0...v5.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/libretime/libretime).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Kyle Robbertze <kyle@paddatrapper.com>
mkolasinski-splunk added a commit to splunk/addonfactory-workflow-addon-release that referenced this pull request Apr 16, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [apache/skywalking-eyes](https://togithub.com/apache/skywalking-eyes)
| action | minor | `v0.5.0` -> `v0.6.0` |
|
[aws-actions/configure-aws-credentials](https://togithub.com/aws-actions/configure-aws-credentials) |
| action | major | `v2` -> `v3` |
| [docker/metadata-action](https://togithub.com/docker/metadata-action) |
| action | minor | `v5.4.0` -> `v5.5.1` |
| [pre-commit/action](https://togithub.com/pre-commit/action) | action |
patch | `v3.0.0` -> `v3.0.1` |

---

### Release Notes

<details>
<summary>apache/skywalking-eyes (apache/skywalking-eyes)</summary>

###
[`v0.6.0`](https://togithub.com/apache/skywalking-eyes/releases/tag/v0.6.0)

[Compare
Source](https://togithub.com/apache/skywalking-eyes/compare/v0.5.0...v0.6.0)

#### What's Changed

- Add `|` as comment indicator by
[@&#8203;kezhenxu94](https://togithub.com/kezhenxu94) in
[apache/skywalking-eyes#168
- Correct the way of joining slack channels by
[@&#8203;wu-sheng](https://togithub.com/wu-sheng) in
[apache/skywalking-eyes#169
- update: add weak-compatible to dependency check by
[@&#8203;Two-Hearts](https://togithub.com/Two-Hearts) in
[apache/skywalking-eyes#171
- feature: add support for Protocol Buffer by
[@&#8203;spacewander](https://togithub.com/spacewander) in
[apache/skywalking-eyes#172
- feature: add support for OPA policy files by
[@&#8203;spacewander](https://togithub.com/spacewander) in
[apache/skywalking-eyes#174
- add Eclipse Foundation specific Apache 2.0 license header by
[@&#8203;gdams](https://togithub.com/gdams) in
[apache/skywalking-eyes#178
- add instructions to fix header issues in markdown comment by
[@&#8203;gdams](https://togithub.com/gdams) in
[apache/skywalking-eyes#179
- bump action/setup-go to v5 by
[@&#8203;gdams](https://togithub.com/gdams) in
[apache/skywalking-eyes#180
- Draft release notes for 0.6.0 by
[@&#8203;kezhenxu94](https://togithub.com/kezhenxu94) in
[apache/skywalking-eyes#181

#### New Contributors

- [@&#8203;Two-Hearts](https://togithub.com/Two-Hearts) made their first
contribution in
[apache/skywalking-eyes#171
- [@&#8203;gdams](https://togithub.com/gdams) made their first
contribution in
[apache/skywalking-eyes#178

**Full Changelog**:
apache/skywalking-eyes@v0.5.0...v0.6.0

</details>

<details>
<summary>aws-actions/configure-aws-credentials
(aws-actions/configure-aws-credentials)</summary>

###
[`v4`](https://togithub.com/aws-actions/configure-aws-credentials/releases/tag/v4)

[Compare
Source](https://togithub.com/aws-actions/configure-aws-credentials/compare/v3...v4)

This tag tracks the latest v4.x.x release

###
[`v3`](https://togithub.com/aws-actions/configure-aws-credentials/releases/tag/v3)

[Compare
Source](https://togithub.com/aws-actions/configure-aws-credentials/compare/v2...v3)

This tag tracks the latest v3.x.x release

</details>

<details>
<summary>docker/metadata-action (docker/metadata-action)</summary>

###
[`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1)

- Don't set `cwd://` prefix for local bake files by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#382

**Full Changelog**:
docker/metadata-action@v5.5.0...v5.5.1

###
[`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0)

[Compare
Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0)

- Set `cwd://` prefix for bake files path by
[@&#8203;crazy-max](https://togithub.com/crazy-max) in
[docker/metadata-action#370
- Bump
[@&#8203;docker/actions-toolkit](https://togithub.com/docker/actions-toolkit)
from 0.16.0 to 0.16.1 in
[docker/metadata-action#371
- Bump moment from 2.29.4 to 2.30.1 in
[docker/metadata-action#373
- Bump moment-timezone from 0.5.43 to 0.5.44 in
[docker/metadata-action#374

**Full Changelog**:
docker/metadata-action@v5.4.0...v5.5.0

</details>

<details>
<summary>pre-commit/action (pre-commit/action)</summary>

###
[`v3.0.1`](https://togithub.com/pre-commit/action/releases/tag/v3.0.1):
pre-commit/action@v3.0.1

[Compare
Source](https://togithub.com/pre-commit/action/compare/v3.0.0...v3.0.1)

##### Misc

- [#&#8203;190](https://togithub.com/pre-commit/action/issues/190) PR by
[@&#8203;SukiCZ](https://togithub.com/SukiCZ).
- [#&#8203;189](https://togithub.com/pre-commit/action/issues/189) issue
by [@&#8203;bakerkj](https://togithub.com/bakerkj).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/splunk/addonfactory-workflow-addon-release).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC40IiwidXBkYXRlZEluVmVyIjoiMzcuMjY5LjIiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: mkolasinski-splunk <mkolasinski@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants