Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update result node version and npm dependencies #140

Merged
merged 3 commits into from Aug 27, 2019
Merged

Update result node version and npm dependencies #140

merged 3 commits into from Aug 27, 2019

Commits on Aug 25, 2019

  1. change result to use local angular 

    To match other .js loading patterns in this repo, don't use a CDN angular, but rather a local copy in case examples are used offline or in large classrooms with slow internet. Also updated to latest angular 1.4
    @BretFisher
    BretFisher committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    368968c View commit details
    Browse the repository at this point in the history

  2. update result to node 10 and latest npm packages 

    The result app was years out of date with node and npm packages, and required multiple changes to use the current supported socket.io and postgres db libs. Minimal changes to server.js to support change in pg syntax. A few minor changes to Dockerfile to improve readability, conform to docker best practices, and change to use npm ci to ensure future builds don't break again due to difference between package and package-lock.
    @BretFisher
    BretFisher committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    793e02e View commit details
    Browse the repository at this point in the history

  3. Changes to node slim to fix Jenkins PR build

    @BretFisher
    BretFisher committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    563773c View commit details
    Browse the repository at this point in the history