Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fin share with --host-header doesn't seem to work #1044

Open
lpeabody opened this issue May 1, 2019 · 0 comments · May be fixed by #1047
Open

fin share with --host-header doesn't seem to work #1044

lpeabody opened this issue May 1, 2019 · 0 comments · May be fixed by #1047
Assignees
Labels

Comments

@lpeabody
Copy link
Sponsor Contributor

lpeabody commented May 1, 2019

Description

fin version 1.85.1

Running fin share --host-header=special.baxter.docksal results in an error:

ERROR:  You must specify a single argument: a port or address to tunnel to.
ERROR:  You specified 0 arguments: []
ERROR:  For example, to expose port 80, run 'ngrok http 80'.

If I insert echo $ARGS after the docker run command in ngrok_share, I get the following output after the command fails:

ngrok http -host-header=special.baxter.docksal

Without the addition of --host-header=special.baxter.docksal the following is output after the command:

ngrok http -host-header 'baxter.docksal' corvette_web_1.corvette_default:80

So, when --host-header is specified it looks like corvette_web_1.corvette_default:80 needs to be attached. If I run fin share --host-header='special.baxter.docksal corvette_web_1.corvette_default:80' then the whole thing works, but I don't think we should have to do that.

@lmakarov lmakarov added this to To do in Docksal 1.13.0 via automation May 1, 2019
@lmakarov lmakarov added this to To do in 1.14.0 via automation Oct 22, 2019
@lmakarov lmakarov removed this from To do in Docksal 1.13.0 Oct 22, 2019
@lmakarov lmakarov removed this from To do in 1.14.0 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants