Fixed issue where ngrok cannot connect to a container if other argument #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sean-e-dietrich so that $container can be set like an ENV var? Should it be all caps then? |
|
@achekulaev i thought about that. Right now we have all lower case flags that are being used with Ngrok but we also allow for uppercase variables to be used. This is the one variable we just modified. So yes, we should allow someone to set it via a variable. |
Made so it would check against variables and see if NGROK_CONTAINER was previously set otherwise default to web
|
Ah it's a flag, I see. Thanks |
achekulaev
reviewed
May 4, 2019
|
Needs to be rebased onto develop and tests updated/fixes (if necessary). |
achekulaev
approved these changes
Oct 16, 2019
|
I don't see any conflicts so rebasing doesn't look like a required step. Approving |
|
Can we just have this done as part of #1048 and ensure tests are green? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1044
This also makes it so if there is a different container other than web