Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cli debugging instructions #1628

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

froboy
Copy link
Contributor

@froboy froboy commented Feb 9, 2022

In attempting to configure Xdebug with PHPStorm to debug with Drush I found that the existing instructions didn't correctly set the PHP_IDE_CONFIG variable, I think because VIRTUAL_HOST is in a different context than docksal-local.env so it's not able to be referenced.

Using the old instructions, this is what I get after fin up:

❯ fin exec printenv PHP_IDE_CONFIG
serverName=

My project is using the default VIRTUAL_HOST (as I'd imagine many are) and not setting it in docksal.env. After setting PHP_IDE_CONFIG in docksal.yml:

❯ fin exec printenv PHP_IDE_CONFIG
serverName=my-project.docksal

@froboy
Copy link
Contributor Author

froboy commented Feb 9, 2022

Removed quotes as per https://stackoverflow.com/a/50176116/2566038.

@sean-e-dietrich
Copy link
Member

@froboy the documentation currently seems valid without the changes.

The PHP_IDE_CONFIG variable is currently present in the cli config https://github.com/docksal/docksal/blob/develop/stacks/services.yml#L148

I'm wondering if the wondering may need to be just changed a little bit to make it a little more apparent that you would need to add a PHP_IDE_CONFIG to debug cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants