Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rename travis -> ci and modify CI docs #66

Merged
merged 1 commit into from Sep 17, 2022

Conversation

agilgur5
Copy link
Contributor

Summary

Do some travis -> ci renaming and modify CI-related docs now that GH Actions are merged

Details

  • now that GH Actions are merged, thoroughly tested, and working:
    • rename travis dir to ci dir instead
    • update release.md to remove Travis references and reference GH Actions files instead
      • and just generic "ci build" instead of "travis build"
      • CI is working now, so uncomment/unquote the previous numbers

Review Notes

  • leave cp_to_travis and reverse_ssh_tunnel as is for now, in case Sylvain wants to adapt them to GH Actions
    • I'm not sure they'll work as-is on GH Actions (e.g. travis_base won't exist), so they may need further modification
      • (or it may not be possible at all with GH Actions to do reverse SSH)
      • that is beyond my scope since I'm not using these, don't have a bounce host, and am developing on a Mac locally

@agilgur5 agilgur5 force-pushed the ci-update-docs-with-gh-actions branch from 49bb6a8 to 40504cf Compare August 28, 2022 17:12
@Sylvain303
Copy link
Collaborator

As I was reviewing #65 I was confused by this one.
It seems mostly OK because based on previous changes integrating github's actions

I don't understand conflict on travis/get_bats-core.sh

Ready to merge when github would be happy.

- now that GH Actions are merged, thoroughly tested, and working:
  - rename `travis` dir to `ci` dir instead
  - update `release.md` to remove Travis references and reference GH Actions files instead
    - and just generic "ci build" instead of "travis build"
    - CI is working now, so uncomment/unquote the previous numbers

- leave `cp_to_travis` and `reverse_ssh_tunnel` as is for now, in case Sylvain wants to adapt them to GH Actions
  - I'm not sure they'll work as-is on GH Actions (e.g. `travis_base` won't exist), so they may need further modification
    - (or it may not be possible at all with GH Actions to do reverse SSH)
    - that is beyond my scope since I'm not using these, don't have a bounce host, and am developing on a Mac locally
@agilgur5 agilgur5 force-pushed the ci-update-docs-with-gh-actions branch from 40504cf to 31b217a Compare September 15, 2022 16:07
@agilgur5
Copy link
Contributor Author

I don't understand conflict on travis/get_bats-core.sh

🤷 I don't know what that was either. I rebased it on master cleanly with no conflicts 🤷

Ready to merge when github would be happy.

Should be good to go now!

@Sylvain303 Sylvain303 merged commit 62aed3d into docopt:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants