Added cleaning of data and asynchronous content loading #534
Conversation
|
What this provides is #528. A concern about this, is what about dynamic documents? How will they reference a document which has now had it's content wiped. If the content fetching, rendering, and whatnot was synchronous, it wouldn't be an issue. However it isn't. |
| content:null | ||
| source:null | ||
| }) | ||
| ### |
There was a problem hiding this comment.
This PR does clean some things up. I see some commented out sections though, is this intentional?
|
@balupton I'd just suggest 🔒 this. Seems pretty out-dated, and I look at it whenever I go on review streaks and then remember it's out. Is there another clean updated PR you'd like opened for it? |
|
Yeah. What we need to do is just take the good bits out of this and keep the bad. It's a complex task, but it does need review. |
| // Output the command we'll be running | ||
| console.log(command.join(' ')); | ||
|
|
||
| // And spawn our command and let us know if any errors occur |
|
I think for the most part, this can actually get merged in. I think what I've done is just commented out the actual functional (non-cleaning) changes in this, which is simply the |
balupton
force-pushed
the
master
branch
7 times, most recently
from
25835e5
to
8afb101
Compare
|
I have become too preoccupied by other things to review, merge, and release this PR. However, you should have received an invite a while ago to join the DocPad Extras Team, which will give you write access to this repository, so you can merge in the PR. For an orientation, or if you need any assistance following the semi-automatic release process from |
Horrified this was not merged, thought it was. Then again #339 is still open.