Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix 1320] the {docsify-updated} in the sample code has been rendered. #1322

Closed
wants to merge 4 commits into from
Closed

[fix 1320] the {docsify-updated} in the sample code has been rendered. #1322

wants to merge 4 commits into from

Conversation

Koooooo-7
Copy link
Member

Summary
fix #1320 , using the js to replace the wrong content.
What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Jul 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/n4kp07vh3
✅ Preview: https://docsify-preview-git-fork-koooooo-7-fix-issue1320.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 31, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8fba01b:

Sandbox Source
docsify-template Configuration

anikethsaha
anikethsaha previously approved these changes Jul 31, 2020
@sy-records
Copy link
Member

see #1321 (comment)

@sy-records sy-records closed this Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The {docsify-updated} in the sample code is parsed into time
3 participants